Review Request: Preffer new hunspell library over the old one in the finder

Tomáš Chvátal tomas.chvatal at gmail.com
Thu Jun 2 17:29:09 BST 2011



> On June 2, 2011, 8:51 a.m., Christoph Feck wrote:
> > HUNSPELL is the only optional dependency that is missing from my kdelibs build, so I cannot test, but if you say it works better this way, please commit :)

Hmm, unless having account on identity mean that I also have write access to kde git repos we can safely assume that I can't commit :)


- Tomáš


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101484/#review3626
-----------------------------------------------------------


On June 1, 2011, 11:10 a.m., Tomáš Chvátal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101484/
> -----------------------------------------------------------
> 
> (Updated June 1, 2011, 11:10 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> When using FindHUNSPELL on system where both hunspell-1.2 and hunspell-1.3 are around the old version is preffered by the finder.
> 
> This patch reverts the logic so the later is preffered.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindHUNSPELL.cmake 9ed944f 
> 
> Diff: http://git.reviewboard.kde.org/r/101484/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tomáš
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110602/a76982b5/attachment.htm>


More information about the kde-core-devel mailing list