Review Request: Fix KUrlNavigator to send raw data (instead of KUrl) to KUriFilter (also fixes bug: 153347)

Mark markg85 at gmail.com
Wed Sep 8 02:57:41 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5284/
-----------------------------------------------------------

(Updated 2010-09-08 01:57:41.225369)


Review request for Dolphin and kdelibs.


Summary (updated)
-------

When a url starts with \\ it can be assumed that the user wants to access a network path. Nothing else starts with \\ anyway.

This patch fixes KUrlNavigator to send the right data to KUriFilter which also fixes at the very least bug 153347.

OK to commit? (since i'm allowed to commit now ^_^)


This addresses bug 153347.
    https://bugs.kde.org/show_bug.cgi?id=153347


Diffs
-----

  trunk/KDE/kdelibs/kfile/kurlnavigator.cpp 1172686 

Diff: http://svn.reviewboard.kde.org/r/5284/diff


Testing
-------

I tested it on some network shares to access it by the windows path names and it seems to work just fine. No issues so far.


Thanks,

Mark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100908/59adc07c/attachment.htm>


More information about the kde-core-devel mailing list