Review Request: Add possibility to translate "About %1" in KAboutApplicationDialog differently when displayed from KPluginSelector

Lasse Liehu lasse.liehu at gmail.com
Thu Oct 14 00:03:27 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5621/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

So the problem is that in my language (Finnish) we either need to have the application name in elative (e.g. Kate => Katesta, Dolphin => Dolphinista) or do something like "About application %1". Since it's not quite practical to include the elative form for every plugin (through pology&transcript) and "About application %1" would look really out of place, I've made this little patch that would solve this issue in a more elegant way, i.e. to translate "About %1" in this case to something like "About plugin %1".

This is basically doing the same thing as the following does for modules' about dialog/menu entry in systemsettings:
menuItem->setText( i18n( "About %1", menuAbout->programName() ) ); in SettingsBase::changeAboutMenu in kdebase/systemsettings/app/SettingsBase.cpp (at line 392, trunk r1185525)

Is this a good idea?


Diffs
-----

  /trunk/KDE/kdelibs/kutils/kpluginselector.cpp 1185525 

Diff: http://svn.reviewboard.kde.org/r/5621/diff


Testing
-------

It compiles and seems to work (not tested with a translation).


Thanks,

Lasse

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101013/aff2f3d2/attachment.htm>


More information about the kde-core-devel mailing list