Review Request: Do not leak kdeuiwidgetsproxystyle

Boudewijn Rempt boud at valdyas.org
Fri Oct 8 12:28:32 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5549/
-----------------------------------------------------------

(Updated 2010-10-08 11:28:32.028795)


Review request for kdelibs.


Changes
-------

Like this?


Summary
-------

For instance in KLineEdit::init(), we have a line like:

d->style = new KLineEditStyle(this);

This gives the impression that KLineEditStyle has QObject-based parent-child relation and will be deleted automatically. That wasn't true, because QStyle while being a QObject doesn't have a QObject* parent paramater in its constructor. So this patch sets the parent explicitly in KdeUiProxyStyle 


Diffs (updated)
-----

  trunk/KDE/kdelibs/kdeui/widgets/klineedit_p.h 1182756 

Diff: http://svn.reviewboard.kde.org/r/5549/diff


Testing
-------


Thanks,

Boudewijn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101008/b56962db/attachment.htm>


More information about the kde-core-devel mailing list