May I add short oneliner patch to 4.5 branch to install forward include header?

Thiago Macieira thiago at kde.org
Fri Aug 6 23:49:38 BST 2010


On Friday 6. August 2010 19.46.41 Milian Wolff wrote:
> Hey there,
> 
> may I still commit this patch to the 4.5 branch:
> 
> diff --git a/includes/CMakeLists.txt b/includes/CMakeLists.txt
> index fc0bbc6..ca068cd 100644
> --- a/includes/CMakeLists.txt
> +++ b/includes/CMakeLists.txt
> @@ -884,6 +884,7 @@ install( FILES
>    KTextEditor/SmartRangeNotifier
>    KTextEditor/SmartRangeWatcher
>    KTextEditor/TemplateInterface
> +  KTextEditor/TemplateInterface2
>    KTextEditor/TextHintInterface
>    KTextEditor/VariableInterface
>    KTextEditor/View
> 
> It's only cosmetic, so definitely nothing that should hold up the release.
> I'm just unsure whether I can commit such fixes in the branches freely.

Side comment: shouldn't all of this (the includes and the installation rules) 
be auto-generated?

-- 
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
  Senior Product Manager - Nokia, Qt Development Frameworks
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100806/a4bb859d/attachment.sig>


More information about the kde-core-devel mailing list