Review Request: AudioDataOutput support in Phonon w/ backends.

Martin Sandsmark sandsmark at samfundet.no
Thu Jul 30 00:10:40 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1129/
-----------------------------------------------------------

(Updated 2009-07-29 23:10:40.078796)


Review request for kdelibs, Ian Monroe and Martin Sandsmark.


Summary
-------

Moves the AudioDataOutput classes out from experimental, and adds support to the Xine and GStreamer Phonon backends.


This addresses bugs 169800 and 199000.
    https://bugs.kde.org/show_bug.cgi?id=169800
    https://bugs.kde.org/show_bug.cgi?id=199000


Diffs
-----

  /trunk/kdesupport/phonon/CMakeLists.txt.orig PRE-CREATION 
  /trunk/kdesupport/phonon/audiodataoutput.h PRE-CREATION 
  /trunk/kdesupport/phonon/audiodataoutput.cpp PRE-CREATION 
  /trunk/kdesupport/phonon/gstreamer/CMakeLists.txt 1002310 
  /trunk/kdesupport/phonon/gstreamer/audiodataoutput.h PRE-CREATION 
  /trunk/kdesupport/phonon/gstreamer/audiodataoutput.cpp PRE-CREATION 
  /trunk/kdesupport/phonon/gstreamer/backend.h 1002310 
  /trunk/kdesupport/phonon/gstreamer/backend.cpp 1002310 
  /trunk/kdesupport/phonon/gstreamer/mediaobject.h 1002310 
  /trunk/kdesupport/phonon/phonon/CMakeLists.txt 1002310 
  /trunk/kdesupport/phonon/phonon/audiodataoutput.h PRE-CREATION 
  /trunk/kdesupport/phonon/phonon/audiodataoutput.cpp PRE-CREATION 
  /trunk/kdesupport/phonon/phonon/audiodataoutput_p.h PRE-CREATION 
  /trunk/kdesupport/phonon/phonon/audiodataoutputinterface.h PRE-CREATION 
  /trunk/kdesupport/phonon/phonon/experimental/CMakeLists.txt 1002310 
  /trunk/kdesupport/phonon/phonon/experimental/audiodataoutput.h 1002310 
  /trunk/kdesupport/phonon/phonon/experimental/audiodataoutput.cpp 1002310 
  /trunk/kdesupport/phonon/phonon/experimental/audiodataoutput_p.h 1002310 
  /trunk/kdesupport/phonon/phonon/experimental/audiodataoutputinterface.h 1002310 
  /trunk/kdesupport/phonon/phonon/experimental/backendinterface.h 1002310 
  /trunk/kdesupport/phonon/phonon/experimental/factory.cpp 1002310 
  /trunk/kdesupport/phonon/phonon/experimental/factory_p.h 1002310 
  /trunk/kdesupport/phonon/phonon/experimental/phononnamespace.h 1002310 
  /trunk/kdesupport/phonon/phonon/factory.cpp 1002310 
  /trunk/kdesupport/phonon/phonon/factory_p.h 1002310 
  /trunk/kdesupport/phonon/xine/audiodataoutput.h 1002310 
  /trunk/kdesupport/phonon/xine/audiodataoutput.cpp 1002310 
  /trunk/kdesupport/phonon/xine/audiooutput.cpp 1002310 
  /trunk/kdesupport/phonon/xine/sinknode.h 1002310 
  /trunk/kdesupport/phonon/xine/sourcenode.h 1002310 
  /trunk/kdesupport/phonon/xine/sourcenode.cpp 1002310 
  /trunk/kdesupport/phonon/xine/xinestream.h 1002310 
  /trunk/kdesupport/phonon/xine/xinestream.cpp 1002310 

Diff: http://reviewboard.kde.org/r/1129/diff


Testing (updated)
-------

It is tested with this: http://gitorious.org/simpleplayer


Screenshots
-----------

proof that it works
  http://reviewboard.kde.org/r/1129/s/153/


Thanks,

Martin





More information about the kde-core-devel mailing list