Review Request: Allow slider to be exponential to the spin box on KDoubleNumInput

Cyrille Berger cberger at cberger.net
Mon Apr 13 20:26:29 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/582/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

Can't seem to be able to update patches on reviewboard :( so creating a new request.

The main point if this patch is to allow to have an "exponential" slider for KDoubleNumInput. It's usefull when you have an input where the main interesting range is small values, while supporting a big range. For instance, in Krita, when we set the radius of the brush we have a range of 0.0 to 9999.0, but most of the time the user work in the range of 0.0-100.0, but since the slider is linear to 0.0 to 9999.0, the most usefull range is only 10% of the slider which makes the slider very unusuable, hence the idea of an exponential slider, where we could make sure the range 0.0-100.0 use half the slider.


Extra goodies, add a few Q_PROPERTY for enabling slider in designer. And it also bring KDoubleNumInput API closer to KIntegerNumInput (unfortunately I can't go further to have the same setRange function as in KIntegerNumInput since it would break ABI)

In this new patch, I have also added step/setStep (and Q_PROPERTY) to change the steps without calling setRange. In the Qt API, it's called setSingleStep, but in knuminput it was refered as "step", not sure if I shouldn't call the new function (and its property) singleStep (and possibly adjust the naming in the other function parameters, when possible) to be closer to Qt's API.


Diffs
-----

  trunk/KDE/kdelibs/kdeui/widgets/knuminput.h 952354 
  trunk/KDE/kdelibs/kdeui/widgets/knuminput.cpp 952354 

Diff: http://reviewboard.kde.org/r/582/diff


Testing
-------


Thanks,

Cyrille





More information about the kde-core-devel mailing list