Review Request: Strip duplicated path separators in KUrlNavigator

Raphael Kubo da Costa kubito at gmail.com
Wed Apr 1 23:24:58 BST 2009


2009/4/1 Ingo Klöcker <kloecker at kde.org>:
> Hi Raphael,
>
> I have received your review request via k-c-d. Did you probably enable
> the option to not receive messages from k-c-d if your address is also
> listed explicitly in the To/CC header?
That's rather strange. Before I sent it today, I could not find my
message in the k-c-d archives. Are you sure you first received my
message on March 29th? In the meantime between sending this message
for the first time and now, I talked to dfaure and he said the first
message wasn't in the moderation queue but hadn't arrived either.

>
>
> Regards,
> Ingo
>
>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://reviewboard.kde.org/r/470/
>> -----------------------------------------------------------
>>
>> Review request for Dolphin and kdelibs.
>>
>>
>> Summary
>> -------
>>
>> This fixes bug 188417: when passing a path with duplicated separators
>> (such as "/tmp//foo" or "/tmp//foo//bar") to KUrlNavigator, the
>> breadcrumb is not displayed correctly (it only shows directories
>> prior to the first duplicated separator -- in this case, '/' and
>> 'tmp').
>>
>> I just don't know if there are problems regarding creating a
>> non-const KUrl url from const KUrl& newUrl in KUrlNavigator::setUrl.
>>
>>
>> This addresses bug 188417.
>>    https://bugs.kde.org/show_bug.cgi?id=188417
>>
>>
>> Diffs
>> -----
>>
>>  /trunk/KDE/kdelibs/kfile/kurlnavigator.cpp 945690
>>
>> Diff: http://reviewboard.kde.org/r/470/diff
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Raphael
>




More information about the kde-core-devel mailing list