Separating kwalletd from kded

[David Faure]

On Saturday 21 June 2008, Lubos Lunak wrote:
> On Friday 20 of June 2008, David Faure wrote:
> > On Friday 20 June 2008, Lubos Lunak wrote:
> > > On Thursday 19 of June 2008, Michael Leupold wrote:
> > > > Hi,
> > > >
> > > > in a short while I will do a commit separating the kwallet daemon from
> > > > kded by making it standalone. This was deemed neccessary as after the
> > > > migration to DBus kpasswdserver and kwalletd couldn't communicate any
> > > > longer because they both lived in kded
> > >
> > >  ??? Are there some more details on this? This looks like a bug in DBUS
> > > and I'd be surprised if we didn't do this in more modules (well,
> > > actually, I'm pretty sure we do).
> >
> > In addition to Thiago's reply to your question, can I remind you of a line
> > you wrote? ;)
> >
> > From kdelibs/TODO:
> > - Prevent re-entering event loop in kded to avoid reentrancy problems like
> > with kwallet in KDE3 (Lubos).
> >
> > The idea of splitting out kwalletd (which shows a modal dialog) out of
> > kded, should make you happy, it solves at least one of the points where
> > kded used to have a sub event loop.
> 
>  That's not really the same issue though, it's perfectly possible to have a 
> dialog without a sub event loop. Connect to its signals, show it, return to 
> the main loop, wait for a slot to be called.

Yes, I know what a non-modal dialog is :-) But if the API is a synchronous call, like "open wallet",
then a non-modal dialog isn't possible without a sub event loop or delayed dbus responses,
both of which are giving us trouble. However you're right, KWalletD is already using delayed
dbus responses, so -if- that was fixed to work in-process then it would be fine inside kded.

This points me to the modal dialog inside kpasswdserver though, this one needs a rework
so that it is made non-modal (but there the API doesn't prevent it, just the code structure
makes it a bit tricky). I can give it a try though.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).