[PATCH] Re: Help, Ok, Cancel KStandardGuiItems

[Michael Pyne]

On Friday 29 August 2008, Allen Winter wrote:
> On Friday 29 August 2008 16:25:30 Allen Winter wrote:
> > Howdy,
> >
> > I noticed that the Help ,Ok and Cancel buttons in KDialogs
> > don't have tooltips or whatsthis. (Help has a tooltip, but no whatsthis).
> >
> > This is due to those settings missing in KStandardGuiItems::ok(), et.al.
> >
> > Is there a good reason for this?  Should I add the tooltips/whatthis
> > to the KStandardGuiItems? Or not? Or maybe add them into
> > the KDialog class directly?
>
> Attached is a patch for review that makes sure Help, Ok and Cancel
> have tooltips and whatsthis.  Let me know if I can commit.
> Or if you have better text.

Instead of saying "When clicking Ok" say "When clicking OK" for consistency 
with the button text (capitalization change).

In addition I'm not sure that

"the settings will be handed over to the program" and
"the settings will be discarded"

are more descriptive.  I think better whatsthis text for OK would be along the 
lines of: "...the changed settings will be applied and the dialog box will be 
closed."  This is an oversimplification (most apps I know apply all settings 
unconditionally whether or not there are changes) but it's generally still 
accurate and I think better describes overall what's happening.

As for Cancel, I think the text should be like "...the dialog box will be 
closed without applying any changes".  I left out "settings" because Cancel is 
a highly overloaded action (what if we're not changing settings but deleting 
files for instance?)

Regards,
 - Michael Pyne
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080829/50b3c0b5/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20080829/50b3c0b5/attachment.sig>