[patch] KIconLoader fallback fix (and slight refactoring)

Jakob Petsovits jpetso at gmx.at
Tue Apr 8 13:18:13 BST 2008


On Tuesday, 8. April 2008, Jakob Petsovits wrote:
> On Tuesday, 8. April 2008, Aaron J. Seigo wrote:
> > On Monday 07 April 2008, Jakob Petsovits wrote:
> > > Hence, I need your review. This patch makes icon interoperability with
> > > naming spec compliant icons actually work, take a bit of time to see if
> > > the code is ok.
> >
> > it looks right; it adds inherited themes, then default themes and
> > addThemeByName ensures there aren't duplicates added. you may want to put
> > a comment in the code that the order of calling (inherited and *then*
> > defaults) is important (and why) just so the code remains a bit more
> > maintainable for future spelunkers. =)
>
> Ok, will do, thanks for the review :)

Applied as r794709.
Forgot to mention you in the commit message, sorry for that.
(I only got it into a follow-up to the commits list.)

Have a great day,
  Jakob




More information about the kde-core-devel mailing list