KDE/kdelibs/kdeui/colors

Matthew Woehlke mw_triad at users.sourceforge.net
Sun Sep 16 20:00:08 BST 2007


Thomas Zander wrote:
> I guess we are past the point where I explain that all I did was remove 
> a lot of duplicate code :-)

I understand that, but please realize that I made a conscious decision 
at the time I originally wrote this code to not write it the way you did.

> What about this patch to finalize the effect-defaults for 'Inactive' being 
> the same as the normal colors?
> [snip patch]

Please change this patch so that the default effect for Inactive is 
IntensityNoEffect, as this is a bit more efficient than amount==0. 
Otherwise, no objections; it will suffice for now.

-- 
Mathew
(sorry, .sig file is on the other computer)





More information about the kde-core-devel mailing list