KPropertiesDialog needs a fix

[Andreas Pakulat]

On 24.12.07 10:48:22, David Faure wrote:
> On Monday 24 December 2007, Andreas Pakulat wrote:
> > On 24.12.07 01:09:58, Aurélien Gâteau wrote:
> > > Rafael Fernández López wrote:
> > > 
> > > > Hi all,
> > > > 
> > > > Tonight I've been trying to fix KPropertiesDialog. Reminding:
> > > > 
> > > > http://media.ereslibre.es/2007/10/propertiesdialog.png
> > > [snip]
> > > > So now, there are some possibilities:
> > > [snip]
> > > > - We could consider using QTabWidget instead of QTabBar for the
> > > > KPropertiesDialog (that is created after all the stuff on
> > > > kdelibs/kdeui/paged/kpageview_p.cpp).
> > > 
> > > Attached patch does this: it makes KPropertiesDialog inherits from KDialog
> > > instead of KPageDialog and set a QTabWidget as the main widget.
> > > What do you think about this?
> > 
> > Isn't this a BIC change and thus not possible anymore until KDE5?
> 
> Hmm really? There have been some BIC changes not so long ago, IIRC...

Well, yes, though there was a RC2 release afterwards and IIRC those
weren't about changing a relatively small (IMHO) bug in the looks of
things. 

Andreas

-- 
If you learn one useless thing every day, in a single year you'll learn
365 useless things.