kdelibs race condition

Oswald Buddenhagen ossi at kde.org
Sun Dec 2 14:39:57 GMT 2007


On Sun, Dec 02, 2007 at 11:41:26AM +0000, Gaël de Chalendar wrote:
> OK. So, would this (below) be a better patch ?
> 
don't paste patches unless you know how to make your editor not break
lines.

> Index: kdecore/config/kconfigini.cpp
> ===================================================================
> --- kdecore/config/kconfigini.cpp       (révision 743893)
> +++ kdecore/config/kconfigini.cpp       (copie de travail)
> @@ -107,7 +106,7 @@
>                  end = start;
>                  for (;;) {
>                      if (end == line.length()) {
> -                        kWarning() << warningProlog(file, lineNo) << "Invalid 
> +                         qWarning() << warningProlog(file, lineNo) 
>
stray space here.

you need to remove the endls everywhere. other than that it is fine, i
guess - i assume you tested it by putting some invalid data in some
config?

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Confusion, chaos, panic - my work here is done.




More information about the kde-core-devel mailing list