Konqueror internals question (hunting an annoying KDE3 usability glitch)

David Faure faure at kde.org
Mon Aug 13 15:31:16 BST 2007


On Monday 13 August 2007, Hans Meine wrote:
>  void KonqViewManager::emitActivePartChanged()
>  {
> +    // prevent unnecessary multiple calls to slotPartActivated:
> +    m_activePartChangedTimer->stop();
>      m_pMainWindow->slotPartActivated( activePart() );
>  }

Good point. I didn't notice that it was called from multiple places
(which is why your bug wasn't fixed, while mine was). It certainly makes sense
to stop the timer in all cases when emitting, please commit this. Thanks!

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list