KRecentFilesAction

Stefan Nikolaus stefan.nikolaus at kdemail.net
Tue Aug 7 15:48:39 BST 2007


On Tuesday 07 August 2007 10:06:13 Stefan Nikolaus wrote:
> On Tuesday 07 August 2007 09:57:10 Stefan Nikolaus wrote:
> > Hi all,
> >
> > the patch (http://rafb.net/p/PLpKH125.html) _prepends_ the most recently
> > opened file to the list of files. Okay to commit?
>
> The only doubt I have about it is wether it's BC. The private class of
> KSelectAction was moved out of KSelectAction
> (KSelectAction::KSelectActionPrivate -> KSelectActionPrivate). That's all
> I've changed in the public header. Should be binary compatible, no?

Attached is a reduced patch without the svn history for the new *_p.h files 
(copied the *.cpp files). I've moved the private classes into the latter, so 
that KRecentFilesActionPrivate is able to inherit from KSelectActionPrivate. 
That is necessary to access the comboboxes etc. in KSelectActionPrivate and 
prepend the action there. This was a TODO in krecentfilesaction.cpp and is 
the KDE3 behaviour.

Regards,
Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: krecentfilesaction.diff
Type: text/x-diff
Size: 9588 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070807/d4525087/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20070807/d4525087/attachment.sig>


More information about the kde-core-devel mailing list