Some remarks on kdebase revision 595286

[Oswald Buddenhagen]

On Sat, Oct 14, 2006 at 01:09:27AM +0200, Christoph Bartoschek wrote:
> - workspace/kdm/kfrontend/kdm_config.c:1299
> 
> If the while loop in line 1188 is never entered acList, then acList is 
> uninitialized here.
> 
irrelevant, as nAcls is then zero.
to generalize this, after the last element acl is always uninitialized.

> - workspace/kdm/kfrontend/genkdmconf.c:461
> 
> Is this memory also freed?
> 
no. genkdmconf leaks a lot, and that's perfectly fine given a total
memory footprint of much less than a meg and a typical run time of much
less than a second.

> - workspace/kdm/backend/ctrl.c:240
> 
> Line 195 indicates that ctrl.path could be NULL here. memcmp does not
> like that.
> 
in that case ffl is zero as well, and thus this should be completely
irrelevant.

thanks for having a look.

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Chaos, panic, and disorder - my work here is done.