Introducing LikeBack - Quick Feedback from Beta-Testers

Sébastien Laoût slaout at linux62.org
Sun Aug 13 22:05:33 BST 2006


Le Dimanche 13 Août 2006 19:26, Tom Albers a écrit :
> And krazy finds some issues:
> http://www.englishbreakfastnetwork.org/krazy/reports/playground/utils/ktu/i
>ndex.html

Attached are the fixed likeback.cpp and likeback.h.
Also with Aaron J. Seigo patch applied.


Note: The test "Check for adding single char string to a QString..." also 
search in comments! It referenced that line (and others) as an error:

	//QString namedMailExpString = "[.]*[ \\t]+<" + mailExpString + ">";

Correction:

	//QString namedMailExpString = "[.]*[ \\t]+<" + mailExpString + '>';

This is a good thing here, because it's effectively a code that can be 
uncommented, but is it wanted to check in comments?


Oh, and it complained about licence has a wrong address but does not tell me 
what is the address I should have added.
I suppose this line:...

    59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.

... should be replaced with:

    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

(from a random file in websvn.kde.org)
(not done in the attached files because I'm not sure)


Who should I contact to propose those "dislike" comments about EBN ? ;-)

Best regards,
Sébastien Laoût.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: likeback.h
Type: text/x-c++hdr
Size: 5202 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060813/392fa059/attachment.h>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: likeback.cpp
Type: text/x-c++src
Size: 23281 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060813/392fa059/attachment.cpp>


More information about the kde-core-devel mailing list