KWin KPixmap removal

Frans Englich englich at kde.org
Sun Apr 30 15:29:23 BST 2006


On Sunday 30 April 2006 07:58, Thiago Macieira wrote:
[...]

> That was completely unnecessary. The only reason to change all include
> style in a file is if it's a public header and it doesn't use the Qt
> module name. All public headers should include the Qt headers in the long
> form (e.g., QtGui/qpixmap.h or QtGui/QPixmap).

Cannot this be enforced by only having QTDIR/include among the includes? 
Otherwise I do not see how it will be followed.

(Same goes with Q_SLOTS/Q_SIGNALS, imho. I think "slots" and "signals" will 
slip into kdelibs unless Q_NO_KEYWORDS is defined.)


Cheers,

		Frans




More information about the kde-core-devel mailing list