Suspicious code in kdebase 3.5.2

[Aaron J. Seigo]

On Saturday 08 April 2006 02:21, Christoph Bartoschek wrote:
> - kcontrol/kicker/hidingtab_impl.cpp:243
>
> If (Left == 7) is always true. Why not "if (trigger == Left)".
>
> - kcontrol/kicker/hidingtab_impl.cpp:265
>
:310:::> if (Left == Left) ? Why not "if (trigger == Left)"

fixed

> - kicker/proxy/appletproxy.cpp:310
>
> If _applet is NULL as indicated by line 277, then line 310 could crash.
>
> - kicker/proxy/extensionproxy.cpp:244
>
> If _extension is NULL as indicated by line 217, then line 244 could
> crash.

fixed

> - kicker/kicker/core/extensionmanager.cpp:143 !!! (at least strange style)
> - kicker/kicker/core/extensionmanager.cpp:262 !!! (at least strange style)

fixed

-- 
Aaron J. Seigo
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

Full time KDE developer sponsored by Trolltech (http://www.trolltech.com)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060408/47bbc6d2/attachment.sig>