Suspicious code in kdebase 3.5.2

[Brad Hards]

On Saturday 08 April 2006 18:21 pm, Christoph Bartoschek wrote:
> - kdialog/kdialog.cpp:135
>
> If this is deleted at line 133 you use a freed this pointer here. Can one
> be sure that no virtual table is checked here?
This code looks wrong to me, although eventFilter() always does...

David: Isn't the delete supposed to be part of the if (id) {} body?

Brad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20060408/29fe8b3e/attachment.sig>