[PATCH] KSaveFile::abort() on win32

Waldo Bastian bastian at kde.org
Wed Mar 30 17:29:28 BST 2005


On Wednesday 30 March 2005 17:30, Oswald Buddenhagen wrote:
> On Wed, Mar 30, 2005 at 04:58:10PM +0100, Jaroslaw Staniek wrote:
> > +++ ksavefile.cpp	30 Mar 2005 14:53:05 -0000
> > @@ -99,8 +99,17 @@
> >  void
> >  KSaveFile::abort()
> >  {
> > +#ifdef Q_WS_WIN
> > +   //for win32: close before unlinking
> > +   QString tmpName( mTempFile.name() );
> > +#else
> >     mTempFile.unlink();
> > +#endif
> >     mTempFile.close();
> > +#ifdef Q_WS_WIN
> > +   if (!tmpName.isEmpty())
> > +      QFile::remove( tmpName );
> > +#endif
> >  }
>
> i think in this case the order is not relevant, so just close it before
> unlinking unconditionally, i'd say. waldo?

I agree.

Cheers,
Waldo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050330/447e5181/attachment.sig>


More information about the kde-core-devel mailing list