[PATCH] fix proxy autodetection with webdav urls.

[Waldo Bastian]

On Monday 07 March 2005 15:50, Thiago Macieira wrote:
> Dawit A. wrote:
> >+            if( p == "webdav" )
> >+              u.setProtocol("http");
> >+            else if ( p == "webdavs" )
> >+              u.setProtocol("https");
> >+
> >+            if ( p.startsWith("http") || p.startsWith("webdav") || p ==
> > "ftp" || p == "gopher" )
> > +              DCOPRef( "kded", "proxyscout" ).call( "proxyForURL",
> > u ).get( proxy );
>
> If you setProtocol to http, it'll never startWith webdav. You might as
> well remove the test and save a few CPU cycles.

That assumes you test against "u.protocol()" instead of "p"

Cheers,
Waldo
-- 
bastian at kde.org   |   Free Novell Linux Desktop 9 Evaluation Download
bastian at suse.com  |   http://www.novell.com/products/desktop/eval.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20050307/0eb535db/attachment.sig>