KDialog / KDialogBase

Mirko Boehm mirko at kde.org
Fri Dec 30 14:11:10 GMT 2005


On Thursday 29 December 2005 13:30, Olivier Goffart wrote:
> Hi
>
> Is there a reason why KDialog and KDialogBase are two separated class ?
>
> maybe they can be merged  (keep only KDialog ?)
>
> should i try it ?
>
> (and for consistency,  FooBase is supposed to be the base of Foo , and not
> the opposite (see KConfigBase))
As the original author of KDialogBase, before someone took it and made a 
C-style janus widget out of it, i do not see the point in having those 2 
classes. 

I also think that the different styles of dialog main widgets should not be in 
there.The whole DialogType thing does not make sense - there can be different 
dialog main widgets, but they do not have to be implemented in the dialog 
class. Those are simply two separate issues. 

Then we shall get rid of the default constructor that is a mile long. This is 
so 80s, it hurts. 

I guess this can be done before KDE4. 

Best regards,
--Mirko.
-- 
KDE e.V.: http://ev.kde.org




More information about the kde-core-devel mailing list