KIconDialog extensions (was: Re: Icon choosing in kedittoolbar)

David Faure faure at kde.org
Sat May 8 22:50:27 BST 2004


On Friday 07 May 2004 18:38, Rob Kaper wrote:
> On Wed, Apr 28, 2004 at 04:01:42PM +0200, David Faure wrote:
> > It's a somewhat particular case, so I don't think it should be an argument in the
> > convenience static method; but you seem to be using the normal constructor
> > and setFoo() methods, so a new method for this is OK, IMHO.
> 
> Here's an untested patch.

Well, you know what to do next, then :)

However the change to the setup() signature is binary incompatible, you should add 
an overloaded method instead, with the two new bools and no default values.

-- 
David Faure, faure at kde.org, sponsored by Trolltech to work on KDE,
Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).




More information about the kde-core-devel mailing list