[PATCH] kdemultimedia/libkcddb/client.cpp

André Wöbbeking Woebbeking at onlinehome.de
Mon Dec 8 00:00:49 GMT 2003


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Sunday 07 December 2003 23:46, Aaron J. Seigo wrote:
> On Sunday 07 December 2003 03:44, André Wöbbeking wrote:
> > here is a trivial patch which prevents libkcddb to crash (in the
> > dtor when cdInfoLookup and cdInfoSubmit are deleted). I don't know
> > why the variables aren't initialized for me, but it shouldn't hurt
> > to initialize them with 0. OK to commit?
>
> looks good.. but i can see some other potential issues here... a more
> comprehensive (and in places perhaps overly-safe) patch attached

yes, I don't know if these are only hypothetical cases but who cares, 
safe is safe :-)

BTW: boost::shared_ptr would be a nice solution for such things.


André
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/0782Gcp/AjG8ndYRAqQ2AJ0dR9Hn6Wt/KkyhFqUVOa4+Yp4AQQCdEgXS
9u5taaQHhxDhRD3y8YkA+Wc=
=ZByD
-----END PGP SIGNATURE-----




More information about the kde-core-devel mailing list