<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28355">View Revision</a></tr></table><br /><div><div><p>I agree with almost all those suggestions. Though it's a lot more complex, so I might need some help with some of that.</p>
<p>As for intended usages, it came up on: <a href="https://phabricator.kde.org/D28305" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D28305</a> for a lot of .service files with a binary location that needs to be derived at configure time. <br />
But it seemed if I made it generic enough it was a pattern that showed up in other locations as shown by porting remaining bits of plasma-workspace: <a href="https://phabricator.kde.org/D28422" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D28422</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28355">https://phabricator.kde.org/D28355</a></div></div><br /><div><strong>To: </strong>davidedmundson<br /><strong>Cc: </strong>kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns<br /></div>