<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D28444">View Revision</a></tr></table><br /><div><div><p>Code per se looks okay, not that I've ever used a rust workspace.</p>
<p>It does need documentation though. See other ECM modules to see what it looks like.</p>
<p>I wonder if this is covering a very widespread use-case. If there's just one application that needs it, it could make sense to keep it there and once it's polished, we put it in ECM to share.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D28444">https://phabricator.kde.org/D28444</a></div></div><br /><div><strong>To: </strong>cblack, Frameworks, Build System<br /><strong>Cc: </strong>apol, IlyaBizyaev, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns<br /></div>