<table><tr><td style="">cgiboudeaux added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26752">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D26752#597149" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D26752#597149</a>, <a href="https://phabricator.kde.org/p/patrickelectric/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@patrickelectric</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Hi <a href="https://phabricator.kde.org/p/cgiboudeaux/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@cgiboudeaux</a> and <a href="https://phabricator.kde.org/p/bcooksley/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@bcooksley</a>, there is a reason of why this patch is valid. Have you read the commit message ?</p>
<p>In <a href="https://phabricator.kde.org/tag/kirogi/" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">#kirogi</a> we provide a valid icon (svg) with a valid prefix (sc), as you probably know *sc* stands for for scalable (SVG) files.</p></div>
</blockquote>
<p>As expected, the problem is in the kirogi code. Read the ECMAddAppIcon doc:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"># The given icons, whose names must match the pattern::
#
# <size>-<other_text>.png</pre></div>
<p>and now look at the kirogi code:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">file(GLOB ICONS_SRCS "${CMAKE_CURRENT_SOURCE_DIR}/../data/icons/*apps-kirogi.svg")
ecm_add_app_icon(kirogi_SRCS ICONS ${ICONS_SRCS})</pre></div>
<p>The warning about Windows is expected.</p>
<p>Now about Apple: if a .svg or .svgz is passed to ecm_add_app_icon, ksvg2icns (if found) will create the icons bundle.</p>
<p>The solution is not hiding the warning when the macro is called on different platform but fixing the condition.</p>
<p>Suggestion: After landing <a href="https://phabricator.kde.org/D26751" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D26751</a>, add a <tt style="background: #ebebeb; font-size: 13px;">else()</tt> block to <tt style="background: #ebebeb; font-size: 13px;">if (NOT (ext STREQUAL "svg" OR ext STREQUAL "svgz"))</tt> where you <tt style="background: #ebebeb; font-size: 13px;">set(_ecm_add_app_icon_svg_icons TRUE)</tt><br />
and change:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (NOT (mac_icons OR mac_sidebar_icons))</pre></div>
<p>to:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">if (NOT (mac_icons OR mac_sidebar_icons) AND NOT _ecm_add_app_icon_svg_icons)</pre></div>
<p>Since ksvg2ico doesn't create the sidebar icons it can be further improved but at least you won't see a warning if you call ecm_add_app_icon with only svg files.</p>
<p>You will only get the warning about the broken behaviour on Windows.</p>
<p>Now another note: kirogi doesn't provide any png icon, this is also bad on Linux. Please create png icons and install them in the hicolor namespace.<br />
See <a href="https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#install_icons" class="remarkup-link" target="_blank" rel="noreferrer">https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#install_icons</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26752">https://phabricator.kde.org/D26752</a></div></div><br /><div><strong>To: </strong>patrickelectric, apol, tcanabrava, cgiboudeaux, bcooksley<br /><strong>Cc: </strong>bcooksley, patrickelectric, apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns<br /></div>