<table><tr><td style="">cullmann added reviewers: broulik, davidedmundson.<br />cullmann added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24568">View Revision</a></tr></table><br /><div><div><p>For the lambda issue, I think we can add:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"># keep lambda formatting multi-line if not empty
AllowShortLambdasOnASingleLine: Empty</pre></div>
<p>see <a href="https://clang.llvm.org/docs/ClangFormatStyleOptions.html" class="remarkup-link" target="_blank" rel="noreferrer">https://clang.llvm.org/docs/ClangFormatStyleOptions.html</a></p>
<p>That fixes for me the issue with the collapsed lambda.</p>
<p>For the comments, as said, we can remove</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">AlignTrailingComments: true</pre></div>
<p>For the generic issue of stuff folded in one line, one can play with the ColumnLimit, but as said, that will still arbitrarily pack stuff as long as it fits the limit.</p>
<p>Kai, could you try the two changes (for lambda and comments) by just temporarily changing that in the .clang-format file locally and rerunning make clang-format?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24568">https://phabricator.kde.org/D24568</a></div></div><br /><div><strong>To: </strong>cullmann, Frameworks, dfaure, broulik, davidedmundson<br /><strong>Cc: </strong>zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns<br /></div>