<table><tr><td style="">kossebau updated this revision to Diff 67620.<br />kossebau marked an inline comment as done.<br />kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23789">View Revision</a></tr></table><br /><div><div><p>switch to do generation-time decision about deprecated(text) attribute usage</p>

<p>GCC/Clang are mostly ABI-compatible, so mixing and linking of artifacts from<br />
both compilers can be expected, so headers should be compatible, too. Though<br />
the compiler versions officially supported for KF (and thus ECM)* both<br />
support <u>attribute</u> ((<u>deprecated</u>(text))), so it can be hardcoded into<br />
the generated header without triggering incompatibilities.<br />
On Windows mixing compilers seems not expected, so compiler detected at<br />
generation time can also be expected at any further header usage time.</p>

<ul class="remarkup-list">
<li class="remarkup-list-item"><a href="https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11" class="remarkup-link" target="_blank" rel="noreferrer">https://community.kde.org/Frameworks/Policies#Frameworks_compiler_requirements_and_C.2B.2B11</a></li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D23789?vs=67584&id=67620">https://phabricator.kde.org/D23789?vs=67584&id=67620</a></div></div><br /><div><strong>BRANCH</strong><div><div>addgenerateexportheader</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23789">https://phabricator.kde.org/D23789</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>docs/module/ECMGenerateExportHeader.rst<br />
modules/ECMGenerateExportHeader.cmake<br />
tests/CMakeLists.txt<br />
tests/ECMGenerateExportHeaderTest/CMakeLists.txt<br />
tests/ECMGenerateExportHeaderTest/consumer/CMakeLists.txt<br />
tests/ECMGenerateExportHeaderTest/consumer/main.cpp<br />
tests/ECMGenerateExportHeaderTest/consumer/testAPI_DISABLE_DEPRECATED_BEFORE_AND_AT.cmake<br />
tests/ECMGenerateExportHeaderTest/consumer/testAPI_NO_DEPRECATED.cmake<br />
tests/ECMGenerateExportHeaderTest/format_version/CMakeLists.txt<br />
tests/ECMGenerateExportHeaderTest/format_version/main.cpp<br />
tests/ECMGenerateExportHeaderTest/library/CMakeLists.txt<br />
tests/ECMGenerateExportHeaderTest/library/library.cpp<br />
tests/ECMGenerateExportHeaderTest/library/library.hpp<br />
tests/ECMGenerateExportHeaderTest/library/main.cpp</div></div></div><br /><div><strong>To: </strong>kossebau, Frameworks, Build System<br /><strong>Cc: </strong>chehrlic, dfaure, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns<br /></div>