<table><tr><td style="">sitter added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23552">View Revision</a></tr></table><br /><div><div><p>No objections from me. This was explicitly suggested during review though, so I'd like <a href="https://phabricator.kde.org/p/cgiboudeaux/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@cgiboudeaux</a> to approve this.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23552#inline-133026">View Inline</a><span style="color: #4b4d51; font-weight: bold;">FindCanberra.cmake:95</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">include</span><span class="p">(</span><span style="color: #766510">FeatureSummary</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #304a96">set_package_properties</span><span class="p">(</span><span style="color: #766510">Canberra</span> <span style="color: #766510">PROPERTIES</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #766510">DESCRIPTION</span> <span style="color: #766510">"Event sound library"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #766510">URL</span> <span style="color: #766510">"http://0pointer.de/lennart/projects/libcanberra"</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can be removed as well.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23552">https://phabricator.kde.org/D23552</a></div></div><br /><div><strong>To: </strong>dfaure, cgiboudeaux, sitter<br /><strong>Cc: </strong>kde-buildsystem, kde-frameworks-devel, apol, aacid, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns<br /></div>