<table><tr><td style="">cgiboudeaux added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22676">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22676#inline-128054">View Inline</a><span style="color: #4b4d51; font-weight: bold;">KDEInstallDirs.cmake:429</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #304a96"><span class="bright">if</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #304a96">get_filename_component</span><span class="p">(</span><span style="color: #766510">_ecm_prefix</span> <span style="color: #766510">"${ECM_DIR}/../../../"</span> <span style="color: #766510">ABSOLUTE</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Might be worth adding that this only works with CMake >= 3.7</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22676#inline-128055">View Inline</a><span style="color: #4b4d51; font-weight: bold;">KDEInstallDirs.cmake:430</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"></span><span style="color: #304a96"><span class="bright">if</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #304a96">get_filename_component</span><span class="p">(</span><span style="color: #766510">_ecm_prefix</span> <span style="color: #766510">"${ECM_DIR}/../../../"</span> <span style="color: #766510">ABSOLUTE</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">CMAKE_INSTALL_PREFIX</span> <span style="color: #766510">"${_ecm_prefix}"</span> <span style="color: #766510">CACHE</span> <span style="color: #766510">PATH</span> <span style="color: #766510">"Install path prefix"</span> <span style="color: #766510">FORCE</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'm not fond of having this hardcoded.</p>

<p style="padding: 0; margin: 8px;">What about adding a new variable in ECMConfig.cmake with the ${PACKAGE_PREFIX_DIR} value instead?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22676">https://phabricator.kde.org/D22676</a></div></div><br /><div><strong>To: </strong>apol<br /><strong>Cc: </strong>cgiboudeaux, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns<br /></div>