<table><tr><td style="">sh-zam created this revision.<br />Herald added projects: Frameworks, Build System.<br />Herald added a subscriber: kde-buildsystem.<br />sh-zam requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D20509">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Don't include same dependency twice, one which was found<br />
from <tt style="background: #ebebeb; font-size: 13px;">readelf</tt> in <tt style="background: #ebebeb; font-size: 13px;">specifydependencies.cmake</tt> and other in<br />
<tt style="background: #ebebeb; font-size: 13px;">ANDROID_EXTRA_LIBS</tt>.</p>
<p>Bug fix: find stl was dependent on the order in which libc++<br />
was added, now it is independent.</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">add the same dependency in ANDROID_EXTRA_LIBS</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D20509">https://phabricator.kde.org/D20509</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>toolchain/ECMAndroidDeployQt.cmake<br />
toolchain/specifydependencies.cmake</div></div></div><br /><div><strong>To: </strong>sh-zam<br /><strong>Cc: </strong>kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns<br /></div>