<table><tr><td style="">bruns created this revision.<br />bruns added a reviewer: Frameworks.<br />Herald added projects: Frameworks, Build System.<br />Herald added subscribers: kde-buildsystem, kde-frameworks-devel.<br />bruns requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14908">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Keep the enum intact by emitting the class keyword in case the enum is<br />
scoped.<br />
Use the complete enum scope for parameter values, the enclosing scope is<br />
only correct to use for unscoped enums.</p>
<p>BUG: 397154</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>build kcoreaddons</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>BRANCH</strong><div><div>scoped_enum</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D14908">https://phabricator.kde.org/D14908</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>find-modules/sip_generator.py</div></div></div><br /><div><strong>To: </strong>bruns, Frameworks<br /><strong>Cc: </strong>kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns<br /></div>