<table><tr><td style="">habacker added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D9446">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">
<li class="remarkup-list-item">doc in file header is missing</li>
<li class="remarkup-list-item">test case is missing</li>
</ul></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9446#inline-72426">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ECMQtDeclareLoggingCategory.cmake:68</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">options</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">oneValueArgs</span> <span style="color: #766510">HEADER</span> <span style="color: #766510">IDENTIFIER</span> <span style="color: #766510">CATEGORY_NAME</span> <span style="color: #766510">DEFAULT_SEVERITY</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">oneValueArgs</span> <span style="color: #766510">HEADER</span> <span style="color: #766510">IDENTIFIER</span> <span style="color: #766510">CATEGORY_NAME</span> <span style="color: #766510">DEFAULT_SEVERITY<span class="bright"></span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">CATEGORY_INSTALL_FILENAME</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">CATEGORY_DESCRIPTION</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">multiValueArgs</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">may be better using shorter names like  INSTALL_FILENAME, DESTINATION  or FILENAME<br />
and DESCRIPTION instead of CATEGORY_DESCRIPTION. because we are declaring a logging category</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D9446#inline-72427">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ECMQtDeclareLoggingCategory.cmake:138</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #304a96">if</span> <span class="p">(</span><span style="color: #766510">ARG_CATEGORY_INSTALL_FILENAME</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #304a96">set</span><span class="p">(</span><span style="color: #766510">CAT_DESCRIPTION</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #304a96">if</span> <span class="p">(</span><span style="color: #766510">ARG_CATEGORY_DESCRIPTION</span><span class="p">)</span> 
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Using ${PROJECT_NAME} if empty ?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D9446">https://phabricator.kde.org/D9446</a></div></div><br /><div><strong>To: </strong>mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt<br /><strong>Cc: </strong>ltoscano, kde-frameworks-devel, kde-buildsystem, habacker, michaelh, ngraham, bruns<br /></div>