<table><tr><td style="">vkrause added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D13403">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D13403#inline-71192">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ECMAndroidDeployQt.cmake:58</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #766510">COMMAND</span> <span style="color: #766510">LANG=C</span> <span style="color: #766510">cmake</span> <span style="color: #766510">-DINPUT_FILE=</span><span style="color: #766510">"${QTANDROID_EXPORTED_TARGET}-deployment.json.in"</span> <span style="color: #766510">-DOUTPUT_FILE=</span><span style="color: #766510">"${QTANDROID_EXPORTED_TARGET}-deployment.json"</span> <span style="color: #766510">"-DTARGET=$<TARGET_FILE:${QTANDROID_EXPORTED_TARGET}>"</span> <span style="color: #766510">"-DOUTPUT_DIR=$<TARGET_FILE_DIR:${QTANDROID_EXPORTED_TARGET}>"</span> <span style="color: #766510">"-DEXPORT_DIR=${CMAKE_INSTALL_PREFIX}"</span> <span style="color: #766510">"-DECM_ADDITIONAL_FIND_ROOT_PATH=\"</span><span style="color: #aa2211">${</span><span style="color: #001294">ECM_ADDITIONAL_FIND_ROOT_PATH</span><span style="color: #aa2211">}</span><span style="color: #766510">\""</span> <span style="color: #766510">"-DANDROID_EXTRA_LIBS=\"</span><span style="color: #aa2211">${</span><span style="color: #001294">ANDROID_EXTRA_LIBS</span><span style="color: #aa2211">}</span><span style="color: #766510">\""</span> <span style="color: #766510">-P</span> <span style="color: #aa2211">${</span><span style="color: #001294">_CMAKE_ANDROID_DIR</span><span style="color: #aa2211">}</span><span style="color: #766510">/specifydependencies.cmake</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #766510">COMMAND</span> <span style="color: #aa2211">$<</span><span style="color: #001294">TARGET_FILE_DIR:Qt5::qmake</span><span style="color: #aa2211">></span><span style="color: #766510">/androiddeployqt</span> <span style="color: #766510">--gradle</span> <span style="color: #766510">--input</span> <span style="color: #766510">"${QTANDROID_EXPORTED_TARGET}-deployment.json"</span> <span style="color: #766510">--output</span> <span style="color: #766510">"${EXPORT_DIR}"</span> <span style="color: #766510">--deployment</span> <span style="color: #766510">bundled</span> <span style="color: #aa2211">${</span><span style="color: #001294">arguments</span><span style="color: #aa2211">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #766510">COMMAND</span> <span style="color: #766510">LANG=C</span> <span style="color: #766510">cmake</span> <span style="color: #766510">-DINPUT_FILE=</span><span style="color: #766510">"${QTANDROID_EXPORTED_TARGET}-deployment.json.in<span class="bright">2</span>"</span> <span style="color: #766510">-DOUTPUT_FILE=</span><span style="color: #766510">"${QTANDROID_EXPORTED_TARGET}-deployment.json"</span> <span style="color: #766510">"-DTARGET=$<TARGET_FILE:${QTANDROID_EXPORTED_TARGET}>"</span> <span style="color: #766510">"-DOUTPUT_DIR=$<TARGET_FILE_DIR:${QTANDROID_EXPORTED_TARGET}>"</span> <span style="color: #766510">"-DEXPORT_DIR=${CMAKE_INSTALL_PREFIX}"</span> <span style="color: #766510">"-DECM_ADDITIONAL_FIND_ROOT_PATH=\"</span><span style="color: #aa2211">${</span><span style="color: #001294">ECM_ADDITIONAL_FIND_ROOT_PATH</span><span style="color: #aa2211">}</span><span style="color: #766510">\""</span> <span style="color: #766510">"-DANDROID_EXTRA_LIBS=\"</span><span style="color: #aa2211">${</span><span style="color: #001294">ANDROID_EXTRA_LIBS</span><span style="color: #aa2211">}</span><span style="color: #766510">\""</span> <span style="color: #766510">-P</span> <span style="color: #aa2211">${</span><span style="color: #001294">_CMAKE_ANDROID_DIR</span><span style="color: #aa2211">}</span><span style="color: #766510">/specifydependencies.cmake</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #766510">COMMAND</span> <span style="color: #aa2211">$<</span><span style="color: #001294">TARGET_FILE_DIR:Qt5::qmake</span><span style="color: #aa2211">></span><span style="color: #766510">/androiddeployqt</span> <span style="color: #766510">--gradle</span> <span style="color: #766510">--input</span> <span style="color: #766510">"${QTANDROID_EXPORTED_TARGET}-deployment.json"</span> <span style="color: #766510">--output</span> <span style="color: #766510">"${EXPORT_DIR}"</span> <span style="color: #766510">--<span class="bright">android-platform</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">$ENV{</span></span><span class="bright"></span><span style="color: #001294"><span class="bright">ANDROID_NDK_PLATFORM</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">}</span></span><span class="bright"> </span><span style="color: #766510"><span class="bright">--</span>deployment</span> <span style="color: #766510">bundled</span> <span style="color: #aa2211">${</span><span style="color: #001294">arguments</span><span style="color: #aa2211">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This seems to introduce a new assumption on ANDRDOID_NDK_PLATFORM being set as an environment variable? Should we check for that/document that, or am I entirely misreading this somehow?</p>

<p style="padding: 0; margin: 8px;">The rest looks good to me.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D13403">https://phabricator.kde.org/D13403</a></div></div><br /><div><strong>To: </strong>apol, Frameworks<br /><strong>Cc: </strong>vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns<br /></div>