<table><tr><td style="">kossebau added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6772" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6772#129531" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6772#129531</a>, <a href="https://phabricator.kde.org/p/apol/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@apol</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Works for me.<br />
 Are you sure we don't need to include the <tt style="background: #ebebeb; font-size: 13px;">TRY</tt> on other calls?</p></div>
</blockquote>

<p>Any calls you would be thinking off? The ones where this patch does not add <tt style="background: #ebebeb; font-size: 13px;">TRY</tt> are in code which expects qmake to exist and the method to return a proper value, and which do not have a fallback plan if it doesn't. Which boils down to the case where the user explicitly set <tt style="background: #ebebeb; font-size: 13px;">KDE_INSTALL_USE_QT_SYS_PATHS</tt> to <tt style="background: #ebebeb; font-size: 13px;">TRUE</tt> but no qmake-qt5 is around.</p>

<p>These are the calls I am aware off, and where TRY is only passed if failing is handled directly or rather indirectly):<br />
kde-modules/KDEInstallDirs.cmake:    query_qmake(qt_install_prefix_dir QT_INSTALL_PREFIX TRY)<br />
kde-modules/KDEInstallDirs.cmake:    query_qmake(qt_plugins_dir QT_INSTALL_PLUGINS)<br />
kde-modules/KDEInstallDirs.cmake:    query_qmake(qt_imports_dir QT_INSTALL_IMPORTS)<br />
kde-modules/KDEInstallDirs.cmake:    query_qmake(qt_qml_dir QT_INSTALL_QML)<br />
kde-modules/KDEInstallDirs.cmake:    query_qmake(qt_docs_dir QT_INSTALL_DOCS)<br />
modules/ECMAddQch.cmake:        query_qmake(qt_docs_dir QT_INSTALL_DOCS TRY)<br />
modules/ECMGeneratePriFile.cmake:    query_qmake(qt_install_prefix_dir QT_INSTALL_PREFIX TRY)<br />
modules/ECMGeneratePriFile.cmake:  query_qmake(qt_host_data_dir QT_HOST_DATA)</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>BRANCH</strong><div><div>handlenoqmakefound</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6772" rel="noreferrer">https://phabricator.kde.org/D6772</a></div></div><br /><div><strong>To: </strong>kossebau, Frameworks, ltoscano, rdieter, apol<br /><strong>Cc: </strong>Build System<br /></div>