<div dir="ltr">I did some negative testing, and from what I can see, 3.8 might well be OK for the ECM fork. My version depends on 3.9 (for example, there are some new constants defined by clang which I use), but I've no idea if this will ever be merged.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 4 April 2017 at 19:08, Heiko Becker <span dir="ltr"><<a href="mailto:noreply@phabricator.kde.org" target="_blank">noreply@phabricator.kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><table><tbody><tr><td>heikobecker added a comment.
</td><td><a style="text-decoration:none;padding:4px 8px;margin:0 8px 8px;float:right;color:#464c5c;font-weight:bold;border-radius:3px;background-color:#f7f7f9;background-image:linear-gradient(to bottom,#fff,#f1f0f1);display:inline-block;border:1px solid rgba(71,87,120,.2)" href="https://phabricator.kde.org/D5289" rel="noreferrer" target="_blank">View Revision</a></td></tr></tbody></table><br><div><div><blockquote style="border-left:3px solid #8c98b8;color:#6b748c;font-style:italic;margin:4px 0 12px 0;padding:8px 12px;background-color:#f8f9fc">
<div style="font-style:normal;padding-bottom:4px">In <a href="https://phabricator.kde.org/D5289#99625" style="background-color:#e7e7e7;border-color:#e7e7e7;border-radius:3px;padding:0 4px;font-weight:bold;color:black;text-decoration:none" rel="noreferrer" target="_blank">D5289#99625</a>, <a href="https://phabricator.kde.org/p/shaheed/" style="border-color:#f1f7ff;color:#19558d;background-color:#f1f7ff;border:1px solid transparent;border-radius:3px;font-weight:bold;padding:0 4px" rel="noreferrer" target="_blank">@shaheed</a> wrote:</div>
<div style="margin:0;padding:0;border:0;color:rgb(107,116,140)"><p>Fwiw, I think that a specific version check may not be needed. The original<br>
code I wrote, which I assume Steve may have simply carried forward in the<br>
cmake ecm logic, DID have a version check but only because the python<br>
bindings were newish circa libclang 3.8.</p></div>
</blockquote>
<p>I'm certainly open to using ClangConfig.cmake and would even prefer it, but I guess I'll wait for feedback from Steve about the version requirement.</p></div></div><br><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5289" rel="noreferrer" target="_blank">https://phabricator.kde.org/<wbr>D5289</a></div></div><br><div><strong>To: </strong>heikobecker, Frameworks, Build System, skelly, kfunk<br><strong>Cc: </strong>rdieter, shaheed, kde-buildsystem, lbeltrame<br></div></blockquote></div><br></div>