<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129900/">https://git.reviewboard.kde.org/r/129900/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Extra Cmake Modules.</div>
<div>By Shaheed Haque.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2017, 7:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Added testing info</p></pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Re-introduce the missing databases. This involved:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1. Restoring the ability for rules_engine.py to be run so as to generate
it own documentation, and support for the following rule databases:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">- Unexposed
- Typecode</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">2. Restoring the corresponding support in sip_generator.py.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">3. Improved diagnostics by making each Rule and AbstractCompiledCodeDb
have a useful names, and then using the results when tracing rule
execution (and usage dumping). This should make it MUCH easier to
debug rule-related issues.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">4. Unit tests for the new functionality.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Added a bunch of unit tests to ECM and then:</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Test project .../extra-cmake-modules
Start 1: GenerateSipBindings
1/49 Test #1: GenerateSipBindings ................................... Passed 17.26 sec
Start 2: ExecuteCoreModules
2/49 Test #2: ExecuteCoreModules .................................... Passed 0.39 sec
Start 3: ExecuteKDEModules
3/49 Test #3: ExecuteKDEModules ..................................... Passed 0.41 sec
Start 4: KDEInstallDirsTest.relative_or_absolute
4/49 Test #4: KDEInstallDirsTest.relative_or_absolute ............... Passed 0.40 sec
Start 5: KDEInstallDirsTest.vars_in_sync_no_args
...</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Verified against KGuiAddons (at cb82278f0b4da446a7859873f3e99ca64c470552).</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Test project .../kguiaddons
Start 1: appstreamtest
1/6 Test #1: appstreamtest .................... Passed 0.02 sec
Start 2: Py3TestKGuiAddons
2/6 Test #2: Py3TestKGuiAddons ................ Passed 0.24 sec
Start 3: Py2TestKGuiAddons
3/6 Test #3: Py2TestKGuiAddons ................ Passed 0.23 sec
Start 4: kwordwraptest
4/6 Test #4: kwordwraptest .................... Passed 0.18 sec
Start 5: kcolorutilstest
5/6 Test #5: kcolorutilstest .................. Passed 0.53 sec</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Reviewed against regression with bulk tools:</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(From module-generator.py)
INFO: Summary: 0 processing errors for 2315 files in 170 modules</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(From module-compiler.py)
ERROR: Summary: 140 processing errors for 165 modules</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(Modules built)
$ find tmp2/python/ -name *.so|wc -l
25</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>find-modules/.gitignore <span style="color: grey">(PRE-CREATION)</span></li>
<li>find-modules/Qt5Ruleset.py <span style="color: grey">(2d8cfaacd1a6e15afe533bc15b6177c49441a852)</span></li>
<li>find-modules/rules_engine.py <span style="color: grey">(955a8eb69115723a5c527d5067dd0d82bb7f968c)</span></li>
<li>find-modules/sip_generator.py <span style="color: grey">(ba9dd636aeb1bf7345f87e5f05bcf530f53f2e2c)</span></li>
<li>tests/GenerateSipBindings/cpplib.h <span style="color: grey">(a91b54864a5d3601a37f8f788fc4f3e9bb8ba323)</span></li>
<li>tests/GenerateSipBindings/rules_SipTest.py <span style="color: grey">(c570a03988e63bf6a03641fa21035ee678dcad22)</span></li>
<li>tests/GenerateSipBindings/testscript.py <span style="color: grey">(e79706bcb2d337484e8ce2098eaacd95c15cae9b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129900/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>