<table><tr><td style="">kfunk added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3850" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D3850#72308" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D3850#72308</a>, <a href="https://phabricator.kde.org/p/rakuco/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@rakuco</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Isn't it better to use <tt style="background: #ebebeb; font-size: 13px;">check_cxx_compiler_flag</tt> to see if the flag is supported and enable it in case it is?</p></div>
</blockquote>

<p>-fno-operator-names is an ancient compiler flag, supported by GCC since at least 2000 [1]. I've also tested Clang, it's supported from at *least* Clang 3.5 there. Intel compiler also supports it since at least 2005 [2]. I don't think we need a <tt style="background: #ebebeb; font-size: 13px;">check_cxx_compiler_flag</tt> here.</p>

<p>[1] <a href="https://gcc.gnu.org/ml/gcc-patches/2000-04/msg00333.html" class="remarkup-link" target="_blank" rel="noreferrer">https://gcc.gnu.org/ml/gcc-patches/2000-04/msg00333.html</a><br />
[2] <a href="https://software.intel.com/en-us/forums/intel-c-compiler/topic/308561" class="remarkup-link" target="_blank" rel="noreferrer">https://software.intel.com/en-us/forums/intel-c-compiler/topic/308561</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R240 Extra CMake Modules</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3850" rel="noreferrer">https://phabricator.kde.org/D3850</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>kfunk, Frameworks, ivan, Buildsystem<br /><strong>Cc: </strong>rakuco, elvisangelaccio<br /></div>