<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129708/">https://git.reviewboard.kde.org/r/129708/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've reverted the change since it was causing compilation problems for anything that uses pthreads
https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/126/console
https://build.kde.org/job/kjs%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/151/console
https://build.kde.org/job/kstars%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/477/console</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I did a 20 minute investigation and the problem is that cmake gets confused because somehow -fsanitize defines pthread_create so it thinks it doesn't need to add pthread library, but we do. Possible solutions are maybe make cmake check a different pthread function, forcing pthread always on if using sanitize address, or something smarter i didn't think of.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This would have happened with the C++ variant but it seems cmake checks for the need for pthread using the C compiler so that's why we had evaded it for now.</p></pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On December 28th, 2016, 1:56 a.m. UTC, Leslie Zhai wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Extra Cmake Modules and Alex Merry.</div>
<div>By Leslie Zhai.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2016, 1:56 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=374195">374195</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So I just added</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>set( CMAKE_C_FLAGS "<span style="color: #BC7A00">${</span>CMAKE_C_FLAGS<span style="color: #BC7A00">}</span> <span style="color: #BC7A00">${</span>XSAN_COMPILE_FLAGS<span style="color: #BC7A00">}</span>" )
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">for C project to use Clang Sanitizer.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">testcase for Clang Static Analyzer, and also for Clang Sanitizer https://github.com/LLVM-China/clang-analyzer.github.io/tree/master/tests</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMEnableSanitizers.cmake <span style="color: grey">(9c8a4de)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129708/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>