<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 5, 2016 at 9:00 AM, Ben Cooksley <span dir="ltr"><<a href="mailto:bcooksley@kde.org" target="_blank">bcooksley@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><span class="">
<table style="border:1px #c9c399 solid;border-radius:6px" width="100%" cellpadding="12" bgcolor="#f9f3c9">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129117/" target="_blank">https://git.reviewboard.kde.<wbr>org/r/129117/</a>
</td>
</tr>
</tbody></table>
<br>
</span><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px"><span class="">
<p style="margin-top:0">On November 5th, 2016, 9:14 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Ship It!</pre>
</blockquote>
</span><span class=""><p>On December 3rd, 2016, 11:36 p.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">I withdraw my approval. Please revert.
I just noticed that these modules have been added for the "frameworks" module-set. This doesn't make sense, they are not part of frameworks. When I type "kdesrc-build frameworks" I expect that only the real KF5 modules will be built.</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">purpose is in playground/libs. If it's needed by kamoso, then it should be moved to extragear/libs and added to kf5-extragear-build-include. Follow the review process for this to happen.</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">kirigami is in extragear/libs. If it's required by discover, it should be moved to kde/workspace, and then it can be added in kf5-workspace-build-include (ask the plasma people if they agree, then file a sysadmin request for the move). If it's also needed by applications, then it needs to be turned into a proper framework.</p></pre>
</blockquote>
</span><span class=""><p>On December 4th, 2016, 9:18 p.m. UTC, <b>Nicolás Alvarez</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word"><p style="padding:0;margin:0;line-height:inherit;white-space:inherit">kamoso in extragear depending on purpose in playground does seem weird, and maybe purpose should be moved to extragear.</p>
<p style="padding:0;margin:0;line-height:inherit;white-space:inherit">However, I don't think a library (kirigami) that is needed by applications should be forced to follow the KF5 release schedule. In terms of versioning, it should be handled the same as a third-party library. They can release when they want, and applications can bump the dependency when they need to.</p></pre>
</blockquote>
</span></blockquote>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I'm with David here. Libraries should also stop abusing KF5* - that prefix is exclusively reserved for Frameworks.</pre></div></div></blockquote><div><br></div><div>I'll revert, but this thread raised concerns that are way way beyond my patch, what I wanted with this was just to be able to compile some KDE software that whas missing, moving an application / library out of playground (that I don't even commited a single line of code) seems to be way out of scope for this change.<br><br></div><div>now, kamoso depends om something that's in playground, not easily reversible, and I wanna have kamoso on my system (I actually use that), should I message the kamoso developers to move purpose out of playground?<br><br></div><div>Tomaz<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">
Due to the manner in which development code often depends on other development code - especially for libraries such as Purpose - i'm strongly in favour of Workspace/Applications only being allowed to depend on libraries in the same release unit or Frameworks (for libraries maintained by KDE anyway).
In any case, depending on Playground should definitely be forbidden (you shouldn't be releasing code from Playground anyway).</pre>
<br>
<p>- Ben</p><span class="">
<br>
<p>On November 7th, 2016, 9:39 a.m. UTC, Tomaz Canabrava wrote:</p>
</span><table style="border:1px #888a85 solid;border-radius:6px" width="100%" cellspacing="0" cellpadding="12" bgcolor="#fefadf">
<tbody><tr>
<td><span class="">
<div>Review request for Build System.</div>
<div>By Tomaz Canabrava.</div>
</span><p style="color:grey"><i>Updated Nov. 7, 2016, 9:39 a.m.</i></p><span class="">
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
kdesrc-build
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" width="100%" cellspacing="0" cellpadding="10" bgcolor="#ffffff">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Kirigami is now needed to run discover, so it should be build
Purpose is needed by at least kamoso.
Signed-off-by: Tomaz Canabrava <<a href="mailto:tcanabrava@kde.org" target="_blank">tcanabrava@kde.org</a>>
Add Kamoso to the buildsystem.
Kamoso was missing from kdegraphics.
Signed-off-by: Tomaz Canabrava <<a href="mailto:tcanabrava@kde.org" target="_blank">tcanabrava@kde.org</a>></pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>kf5-applications-build-include <span style="color:grey">(<wbr>f53c0233ba46322829076db3437cf9<wbr>c62a65ff8e)</span></li>
<li>kf5-frameworks-build-include <span style="color:grey">(<wbr>a88498e3248262d2e1fddacd726e1e<wbr>f06a3ac1e4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129117/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</span></td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br></div></div>