<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129117/">https://git.reviewboard.kde.org/r/129117/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Noviembre 5th, 2016, 6:14 a.m. ART, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
</blockquote>
<p>On Diciembre 3rd, 2016, 8:36 p.m. ART, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I withdraw my approval. Please revert.
I just noticed that these modules have been added for the "frameworks" module-set. This doesn't make sense, they are not part of frameworks. When I type "kdesrc-build frameworks" I expect that only the real KF5 modules will be built.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">purpose is in playground/libs. If it's needed by kamoso, then it should be moved to extragear/libs and added to kf5-extragear-build-include. Follow the review process for this to happen.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kirigami is in extragear/libs. If it's required by discover, it should be moved to kde/workspace, and then it can be added in kf5-workspace-build-include (ask the plasma people if they agree, then file a sysadmin request for the move). If it's also needed by applications, then it needs to be turned into a proper framework.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kamoso in extragear depending on purpose in playground does seem weird, and maybe purpose should be moved to extragear.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">However, I don't think a library (kirigami) that is needed by applications should be forced to follow the KF5 release schedule. In terms of versioning, it should be handled the same as a third-party library. They can release when they want, and applications can bump the dependency when they need to.</p></pre>
<br />
<p>- Nicolás</p>
<br />
<p>On Noviembre 7th, 2016, 6:39 a.m. ART, Tomaz Canabrava wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Build System.</div>
<div>By Tomaz Canabrava.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2016, 6:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesrc-build
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kirigami is now needed to run discover, so it should be build
Purpose is needed by at least kamoso.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
Add Kamoso to the buildsystem.
Kamoso was missing from kdegraphics.
Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kf5-applications-build-include <span style="color: grey">(f53c0233ba46322829076db3437cf9c62a65ff8e)</span></li>
<li>kf5-frameworks-build-include <span style="color: grey">(a88498e3248262d2e1fddacd726e1ef06a3ac1e4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129117/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>