<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129367/">https://git.reviewboard.kde.org/r/129367/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Missed this one before and already pushed an quickgit->cgit update for the links (as it seemed an obvious change, exactly done as proposed here, https://cgit.kde.org/extra-cmake-modules.git/commit/?id=6cf1f9ed32875be2b279c6da9935d89e505e37ee), so +1 as well (also not being ECM maintainer, but then there seems noone and community rather is maintaining).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Still needs the homepage and api link changes from this patch.</p></pre>
<br />
<p>- Friedrich W. H. Kossebau</p>
<br />
<p>On November 15th, 2016, 10:53 a.m. UTC, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Build System and Extra Cmake Modules.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2016, 10:53 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">https://commits.kde.org/<repo>?path=...&branch=... is guaranteed to redirect to the proper repository browser.
Add a link to the generated ECM documentation.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>README.rst <span style="color: grey">(f3e98aa)</span></li>
<li>kde-modules/KDECMakeSettings.cmake <span style="color: grey">(6e53cb1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129367/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>