<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129140/">https://git.reviewboard.kde.org/r/129140/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll leave the decision up to you, but I think this should only be added if <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">peruse</code>'s presence in playground is simply temporary, and that it's currently planned to move to kde/kdegraphics or similar. There are a whole lot of modules in playground/base alone, so I want to be careful of how many of them get added to the default KF5 build.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If it's not planned to move to kde/kdegraphics, you could still add it as part of a commented module-set (probably in kf5-applications-build-include) to show off the playground git repositories. Something like:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>module-set playground-modules
repository kde-projects
<span style="color: #408080; font-style: italic"># Uncomment the following line to build software programs that are still under development</span>
<span style="color: #408080; font-style: italic">#use-modules peruse kio-mtp</span>
<span style="color: #008000">end</span> module-set
</pre></div>
</p></pre>
<br />
<p>- Michael Pyne</p>
<br />
<p>On October 10th, 2016, 11:46 a.m. UTC, Tomaz Canabrava wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Build System.</div>
<div>By Tomaz Canabrava.</div>
<p style="color: grey;"><i>Updated Oct. 10, 2016, 11:46 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdesrc-build
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kf5-applications-build-include <span style="color: grey">(f53c0233ba46322829076db3437cf9c62a65ff8e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129140/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>