<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128848/">https://git.reviewboard.kde.org/r/128848/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Extra Cmake Modules and Aleix Pol Gonzalez.</div>
<div>By Andreas Cord-Landwehr.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Create a module named "ECMAddApkPackageTarget" that handles
all APK packaging logic for Android builds. This will helper
in a later integration of APK creation for autotests.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Manual build testing</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>modules/ECMAddApkPackageTarget.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>modules/ECMAddApkPackageTarget_dependencyHelper.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(dd1350ada4d2316a3329e4f4fcdcd74c628ab30e)</span></li>
<li>tests/ECMToolchainAndroidTest/CMakeLists.txt <span style="color: grey">(eb2ae2980140c32e9d5c9c7c38913fd5420021d3)</span></li>
<li>tests/ECMToolchainAndroidTest/main.c <span style="color: grey">()</span></li>
<li>tests/ECMToolchainAndroidTest/testlinkfile/CMakeFiles/testtarget.dir/link.txt <span style="color: grey">()</span></li>
<li>tests/ECMToolchainAndroidTest/testlinkfile/outputfake.json <span style="color: grey">()</span></li>
<li>toolchain/Android.cmake <span style="color: grey">(20e65f87ac5a4fe9a0089c596d1d392214053817)</span></li>
<li>toolchain/deployment-file.json.in <span style="color: grey">()</span></li>
<li>toolchain/specifydependencies.cmake <span style="color: grey">(65e875bf23a7e22f56fbfad3df8c22e1444bd9ea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128848/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>