<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128780/">https://git.reviewboard.kde.org/r/128780/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Build System.</div>
<div>By Allen Winter.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Put the full BSD3 license text into all files.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The reason is because I am using some ECM stuff in non-KDE projects and it's a pain to replace the text in the copied files. I'd rather have it done once and for all in the real ECM package and this way I won't forget to replace the text as required</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">make test still passes 100%</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(140f257)</span></li>
<li>docs/CMakeLists.txt <span style="color: grey">(1f30785)</span></li>
<li>docs/manual/ecm-developer.7.rst <span style="color: grey">(3ed3f78)</span></li>
<li>kde-modules/KDECMakeSettings.cmake <span style="color: grey">(46fd10a)</span></li>
<li>kde-modules/KDECompilerSettings.cmake <span style="color: grey">(6cecefd)</span></li>
<li>kde-modules/KDEFrameworkCompilerSettings.cmake <span style="color: grey">(e41003d)</span></li>
<li>kde-modules/KDEInstallDirs.cmake <span style="color: grey">(e9878e6)</span></li>
<li>kde-modules/KDEPackageAppTemplates.cmake <span style="color: grey">(b8c1ce7)</span></li>
<li>modules/ECMAddAppIcon.cmake <span style="color: grey">(ca64314)</span></li>
<li>modules/ECMAddTests.cmake <span style="color: grey">(e9e2fc5)</span></li>
<li>modules/ECMCoverageOption.cmake <span style="color: grey">(4c1db9d)</span></li>
<li>modules/ECMCreateQmFromPoFiles.cmake <span style="color: grey">(b419472)</span></li>
<li>modules/ECMEnableSanitizers.cmake <span style="color: grey">(aa7092d)</span></li>
<li>modules/ECMFindModuleHelpers.cmake <span style="color: grey">(6a08b04)</span></li>
<li>modules/ECMGenerateHeaders.cmake <span style="color: grey">(cefc82d)</span></li>
<li>modules/ECMGeneratePkgConfigFile.cmake <span style="color: grey">(eaef7b4)</span></li>
<li>modules/ECMGeneratePriFile.cmake <span style="color: grey">(098431d)</span></li>
<li>modules/ECMInstallIcons.cmake <span style="color: grey">(730bde7)</span></li>
<li>modules/ECMMarkAsTest.cmake <span style="color: grey">(9027bf3)</span></li>
<li>modules/ECMMarkNonGuiExecutable.cmake <span style="color: grey">(59737d4)</span></li>
<li>modules/ECMOptionalAddSubdirectory.cmake <span style="color: grey">(2b89005)</span></li>
<li>modules/ECMPackageConfigHelpers.cmake <span style="color: grey">(d1d0408)</span></li>
<li>modules/ECMPoQmTools.cmake <span style="color: grey">(2547df1)</span></li>
<li>modules/ECMQtDeclareLoggingCategory.cmake <span style="color: grey">(c125949)</span></li>
<li>modules/ECMSetupVersion.cmake <span style="color: grey">(33d0ada)</span></li>
<li>modules/ECMUninstallTarget.cmake <span style="color: grey">(1e9bb91)</span></li>
<li>modules/ECMUseFindModules.cmake <span style="color: grey">(0a8a40f)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(dd1350a)</span></li>
<li>toolchain/Android.cmake <span style="color: grey">(6e3cf6c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128780/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>