<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128533/">https://git.reviewboard.kde.org/r/128533/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The test fails in CI (and locally for me), please fix ;)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://build.kde.org/view/Frameworks%20kf5-qt5/job/kpackage%20master%20kf5-qt5/88/PLATFORM=Linux,compiler=gcc/testReport/junit/(root)/TestSuite/testfallbackpackage_appstream/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">http://ci-logs.kde.flaska.net/1f/1fdab49485172a5693ecddf48d7640c481e23298/rebuilddep/rebuilddep-kf5-qt57-clang-el7/531a3ae/shell_output.log</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Locally: diff -bB <src>/kpackage/autotests/data/testfallbackpackage/testfallbackpackage.appdata.xml <build>/kpackage/autotests/testfallbackpackage.appdata.xml
shows that the latter has many more translations, and uses en_GB while the former uses en-GB. http://www.davidfaure.fr/2016/testfallbackpackage.appdata.diff.txt</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To compare XML files, what I did in kdsoap is to put them both into QDomDocument and then use toString(), and then compare. It even allows showing the actual line of the first difference (while the technique used here only shows "files differ"). You can reuse that code, it's LGPL: xmlBufferCompare() at https://github.com/KDAB/KDSoap/blob/master/testtools/httpserver_p.cpp
This would help with any sort of formatting issue (indentation, casing of "utf-8" etc), but obviously not with the different amount of translations, you'd need to remove the translations from the DOM tree first.</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On August 4th, 2016, 11:03 a.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Build System, Extra Cmake Modules, KDE Frameworks, Matthias Klumpp, Scarlett Clark, and Harald Sitter.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Aug. 4, 2016, 11:03 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">At the moment, we're validating it in build.kde.org, but I feel it will be easier for developers to test if we do so locally.
This patch does it by seeing which <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">*.appdata.xml</code> files are being installed and validating them. This way we can keep it generic for all KDE projects.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on some projects, locally.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kde-modules/KDECMakeSettings.cmake <span style="color: grey">(dd37e7f)</span></li>
<li>kde-modules/appstreamtest.cmake <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128533/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>