<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125631/">https://git.reviewboard.kde.org/r/125631/</a>
     </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Extra Cmake Modules and Volker Krause.</div>
<div>By Alex Merry.</div>










<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
extra-cmake-modules
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ECMInstallIcons now updates the theme cache if gtk-update-icon-cache is
available, producing files the test hadn't been expecting.. Updating the
test revealed that the old-style ecm_install_icons call only updated the
hicolor cache, and not any of the other themes.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">make test</code> now reports 100% tests passed.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>modules/ECMInstallIcons.cmake <span style="color: grey">(920c94908e2de4177eb4966317ade74d3bda89e9)</span></li>

 <li>tests/ECMInstallIconsTest/CMakeLists.txt <span style="color: grey">(7fe4ca35568ddb4aa6abecdc2f24de559f5ad9dc)</span></li>

 <li>tests/ECMInstallIconsTest/check_tree.cmake.in <span style="color: grey">(6d14246b94bbfa801c497af92878cff9cb979184)</span></li>

 <li>tests/ECMInstallIconsTest/expected-tree/badly-named-files-test/hicolor/icon-theme.cache <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/ECMInstallIconsTest/expected-tree/lang-test/hicolor/icon-theme.cache <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/ECMInstallIconsTest/expected-tree/multi-file-test/hicolor/icon-theme.cache <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/ECMInstallIconsTest/expected-tree/single-file-test/hicolor/icon-theme.cache <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/ECMInstallIconsTest/expected-tree/themed-lang-test/oxygen/icon-theme.cache <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/ECMInstallIconsTest/expected-tree/themed-test/theme-name-2/icon-theme.cache <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/ECMInstallIconsTest/expected-tree/v1-icons/crystalsvg/icon-theme.cache <span style="color: grey">(PRE-CREATION)</span></li>

 <li>tests/ECMInstallIconsTest/expected-tree/v1-icons/hicolor/icon-theme.cache <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125631/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>